Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: message details tab counter [WPB-8798] #2914

Merged
merged 1 commit into from
Apr 19, 2024
Merged

fix: message details tab counter [WPB-8798] #2914

merged 1 commit into from
Apr 19, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Apr 19, 2024 •
edited by github-actions bot
Loading

BugWPB-8798 [Android] Crash when opening message details

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Count arguments were not properly passed to tab title string resource

@Garzas Garzas requested review from saleniuk and a team April 19, 2024 10:17
@Garzas Garzas self-assigned this Apr 19, 2024
@Garzas Garzas requested review from typfel, yamilmedina, alexandreferris and MohamadJaara and removed request for a team April 19, 2024 10:17
@Garzas Garzas enabled auto-merge April 19, 2024 10:26
@Garzas Garzas added this pull request to the merge queue Apr 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Test Results

900 tests  ±0   900 ✅ ±0   12m 56s ⏱️ - 1m 6s
122 suites ±0     0 💤 ±0 
122 files   ±0     0 ❌ ±0 

Results for commit ed16e1a. ± Comparison against base commit c4c92ed.

@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 3019bb9 Apr 19, 2024
12 of 13 checks passed
@Garzas Garzas deleted the fix/message-details-tab-count branch April 19, 2024 11:24
@AndroidBob
Copy link
Collaborator

Build 4335 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saleniuk saleniuk saleniuk approved these changes

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@alexandreferris alexandreferris Awaiting requested review from alexandreferris alexandreferris was automatically assigned from wireapp/android

Assignees

@Garzas Garzas

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Garzas @AndroidBob @yamilmedina @MohamadJaara @saleniuk